errose28 commented on code in PR #7065:
URL: https://github.com/apache/ozone/pull/7065#discussion_r1722389471


##########
hadoop-hdds/container-service/src/main/java/org/apache/hadoop/ozone/container/keyvalue/KeyValueHandler.java:
##########
@@ -516,6 +517,7 @@ ContainerCommandResponseProto handleCloseContainer(
     try {
       markContainerForClose(kvContainer);
       closeContainer(kvContainer);
+      createContainerMerkleTree(kvContainer);

Review Comment:
   Update after some discussion: when there is an error, the system will not 
persist the data. That means for quasi-closed and unhealthy containers, the 
metadata in rocksdb should still reflect the data on the disk at the time of 
write. Therefore we can use this method to update all containers that 
transition out of the closing state.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to