errose28 commented on code in PR #7065:
URL: https://github.com/apache/ozone/pull/7065#discussion_r1723724614
##########
hadoop-hdds/container-service/src/test/java/org/apache/hadoop/ozone/container/checksum/ContainerMerkleTreeTestUtils.java:
##########
@@ -87,8 +91,8 @@ public static void
assertTreesSortedAndMatch(ContainerProtos.ContainerMerkleTree
* "bytesPerChecksum" amount of data and are assumed to be contiguous.
* @return The ChunkInfo proto object built from this information.
*/
- public static ChunkInfo buildChunk(ConfigurationSource config, int
indexInBlock, ByteBuffer... chunkChecksums)
- throws IOException {
+ public static ContainerProtos.ChunkInfo buildChunk(ConfigurationSource
config, int indexInBlock,
Review Comment:
I had been doing it with `ContainerProtos.ChunkInfo` too since there is the
other existing Java object called `ChunkInfo`. IDE will differentiate them
though, so it's a toss up which one is more readable.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
