szetszwo commented on code in PR #7150: URL: https://github.com/apache/ozone/pull/7150#discussion_r1742328258
########## pom.xml: ########## @@ -1531,6 +1531,17 @@ xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xs <allowedImport>org.rocksdb.TransactionLogIterator.BatchResult</allowedImport> <allowedImport>org.rocksdb.TickerType</allowedImport> <allowedImport>org.rocksdb.LiveFileMetaData</allowedImport> + <allowedImport>org.rocksdb.AccessHint</allowedImport> + <allowedImport>org.rocksdb.BuiltinComparator</allowedImport> + <allowedImport>org.rocksdb.ChecksumType</allowedImport> + <allowedImport>org.rocksdb.CompactionPriority</allowedImport> + <allowedImport>org.rocksdb.CompactionStopStyle</allowedImport> + <allowedImport>org.rocksdb.CompressionType</allowedImport> + <allowedImport>org.rocksdb.DataBlockIndexType</allowedImport> + <allowedImport>org.rocksdb.IndexShorteningMode</allowedImport> + <allowedImport>org.rocksdb.IndexType</allowedImport> + <allowedImport>org.rocksdb.PrepopulateBlobCache</allowedImport> + <allowedImport>org.rocksdb.WALRecoveryMode</allowedImport> Review Comment: Could we move the new classes to `hadoop-hdds/managed-rocksdb/...` instead of adding `allowedImport`? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
