errose28 commented on PR #7150: URL: https://github.com/apache/ozone/pull/7150#issuecomment-2327495975
@kerneltime I agree. I made the same [suggestion](https://github.com/apache/ozone/pull/7117#issuecomment-2310925940) in #7117 with a pointer to the [RocksDB docs](https://github.com/facebook/rocksdb/wiki/RocksDB-Options-File). The approach taken here is not sustainable to maintain and also less intuitive than having Ozone work with RocksDB's config file exactly how RocksDB documents it. This `DBProfile` abstraction is old and not really used as far as I know. It might be better to just get rid of it. We can instead directly provide example RocksDB config files for different use cases. This will be much easier to follow than hiding the tuning inside the Java code. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
