sumitagrawl commented on code in PR #7161:
URL: https://github.com/apache/ozone/pull/7161#discussion_r1745276027
##########
hadoop-ozone/client/src/main/java/org/apache/hadoop/ozone/client/rpc/RpcClient.java:
##########
@@ -2305,19 +2304,16 @@ public List<OzoneFileStatus> listStatus(String
volumeName, String bucketName,
String keyName, boolean recursive, String startKey,
long numEntries, boolean allowPartialPrefixes) throws IOException {
OmKeyArgs keyArgs = prepareOmKeyArgs(volumeName, bucketName, keyName);
- return ozoneManagerClient
- .listStatus(keyArgs, recursive, startKey, numEntries,
- allowPartialPrefixes);
- }
-
- @Override
- public List<OzoneFileStatusLight> listStatusLight(String volumeName,
- String bucketName, String keyName, boolean recursive, String startKey,
- long numEntries, boolean allowPartialPrefixes) throws IOException {
- OmKeyArgs keyArgs = prepareOmKeyArgs(volumeName, bucketName, keyName);
- return ozoneManagerClient
- .listStatusLight(keyArgs, recursive, startKey, numEntries,
- allowPartialPrefixes);
+ if (omVersion.compareTo(OzoneManagerVersion.LIGHTWEIGHT_LIST_STATUS) >= 0)
{
Review Comment:
listStatus() is exposed interface via OzoneBucket for the client code, if
some external has integrated, can impact the compatibility.
For newer client, if new interface is used and OM do not have that, it will
return command not found. In that case, client can call old interface and
convert output. This will provide better compatibility. And since this case is
rare where client is new and server is old, this extra call for the duration
should be enough.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
