errose28 commented on code in PR #7161:
URL: https://github.com/apache/ozone/pull/7161#discussion_r1745811312
##########
hadoop-ozone/client/src/main/java/org/apache/hadoop/ozone/client/rpc/RpcClient.java:
##########
@@ -2305,19 +2304,16 @@ public List<OzoneFileStatus> listStatus(String
volumeName, String bucketName,
String keyName, boolean recursive, String startKey,
long numEntries, boolean allowPartialPrefixes) throws IOException {
OmKeyArgs keyArgs = prepareOmKeyArgs(volumeName, bucketName, keyName);
- return ozoneManagerClient
- .listStatus(keyArgs, recursive, startKey, numEntries,
- allowPartialPrefixes);
- }
-
- @Override
- public List<OzoneFileStatusLight> listStatusLight(String volumeName,
- String bucketName, String keyName, boolean recursive, String startKey,
- long numEntries, boolean allowPartialPrefixes) throws IOException {
- OmKeyArgs keyArgs = prepareOmKeyArgs(volumeName, bucketName, keyName);
- return ozoneManagerClient
- .listStatusLight(keyArgs, recursive, startKey, numEntries,
- allowPartialPrefixes);
+ if (omVersion.compareTo(OzoneManagerVersion.LIGHTWEIGHT_LIST_STATUS) >= 0)
{
Review Comment:
What is the actual exception corresponding to "command not found"? Do we get
something that clean or is it just a general protobuf parsing error like the
one shown in the PR description? We use versions to avoid having to make
compatibility assumptions based on vague protobuf exceptions.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
