swamirishi commented on code in PR #7188:
URL: https://github.com/apache/ozone/pull/7188#discussion_r1757333412
##########
hadoop-ozone/ozone-manager/dev-support/findbugsExcludeFile.xml:
##########
@@ -89,4 +89,9 @@
<Class
name="org.apache.hadoop.ozone.om.upgrade.TestOMLayoutFeatureAspect"/>
<Bug pattern="BC_IMPOSSIBLE_CAST" />
</Match>
+ <Match>
+ <Class name="org.apache.hadoop.ozone.om.ratis.OzoneManagerDoubleBuffer" />
+ <Field name="readyBuffer" />
+ <Bug pattern="IS2_INCONSISTENT_SYNC" />
+ </Match>
Review Comment:
We don't need an object lock on double buffer. That would impact the entire
write flow. Only flushing daemon uses this readBuffer. Active writes happen to
current buffer we shouldn't be blocking that. Object lock will block that.
Ideally we could have implemented individual locks than depending on the entire
object lock. This would be more optimized.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
