ArafatKhan2198 commented on code in PR #7229:
URL: https://github.com/apache/ozone/pull/7229#discussion_r1771348398


##########
hadoop-ozone/tools/src/main/java/org/apache/hadoop/ozone/debug/container/ContainerCommands.java:
##########
@@ -93,6 +93,8 @@ public class ContainerCommands implements Callable<Void>, 
SubcommandWithParent {
   @Spec
   private CommandSpec spec;
 
+  private String dataPath;

Review Comment:
   Thanks for the suggestion @ashishkumar50! We can't define 
`@CommandLine.Option` in `ContainerCommands` because it would require users to 
specify the `--path` option before the subcommand (e.g., list). This led to 
command structure issues earlier, so we decided to keep it at the subcommand 
level to allow a more natural flow, like:
   
   For example, instead of writing:
   
   ```
   ozone debug container list --path=/data/hdds
   ```
   users would have to write:
   ```
   ozone debug container --path=/data/hdds list
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to