ArafatKhan2198 commented on code in PR #7229:
URL: https://github.com/apache/ozone/pull/7229#discussion_r1772925540
##########
hadoop-ozone/tools/src/main/java/org/apache/hadoop/ozone/debug/container/ListSubcommand.java:
##########
@@ -37,8 +37,18 @@ public class ListSubcommand implements Callable<Void> {
@CommandLine.ParentCommand
private ContainerCommands parent;
+ @CommandLine.Option(names = {"--path", "-p"},
Review Comment:
Ok so I thought It reads more like natural language, saying "list containers
at this path."
But I agree Here, --path is placed right after container, which makes more
sense because it’s a shared option for all subcommands (like list, info, etc.).
This way, the path is applied globally before the specific subcommand is
executed.
I'll make changes as suggested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
