sodonnel commented on PR #7237: URL: https://github.com/apache/ozone/pull/7237#issuecomment-2377011308
> If I plan to recreate the ThreadPoolExecutor, do you think this approach is appropriate I am not sure - it would be tricky, as you will need to let all the pending tasks complete, which could take a long time and then create a new executor. The default queue size of 4096 should be large enough though. SCM will only send enough commands to the datanode based on its streams count - unless the streams are very high I would not expect the queue to get filled. The main point of my earlier comment, is that by making that entire class configurable you haven't make the "service" reconfigurable as there needs to be a callback registered to update the service config. There may also be some configs in that class which don't really need to be configurable, eg the zeroCopy one. It might be better to list out the individual configs and register a callback for each one in turn. However, as it stands, the most important config is already reconfigurable, as the maxStreams is the one that throttles the replication througput. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
