weimingdiit commented on PR #7237: URL: https://github.com/apache/ozone/pull/7237#issuecomment-2378460267
> The main point of my earlier comment, is that by making that entire class configurable you haven't make the "service" reconfigurable as there needs to be a callback registered to update the service config. There may also be some configs in that class which don't really need to be configurable, eg the zeroCopy one. > > It might be better to list out the individual configs and register a callback for each one in turn. @sodonnel Thanks for your reminder, I have realized this, only making that entire class configurable is not enough >However, as it stands, the most important config is already reconfigurable, as the maxStreams is the one that throttles the replication througput. The most important configuration **hdds.datanode.replication.streams.limit** can be reconfigured, which is enough for replication i think. Maybe I should close this PR. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
