xichen01 commented on code in PR #7249:
URL: https://github.com/apache/ozone/pull/7249#discussion_r1799809804
##########
hadoop-hdds/server-scm/src/main/java/org/apache/hadoop/hdds/scm/block/DeletedBlockLogImpl.java:
##########
@@ -369,12 +372,13 @@ public DatanodeDeletedBlockTransactions getTransactions(
if (checkInadequateReplica(replicas, txn)) {
continue;
}
+ metrics.setNumBlockDeletionTransactionDataNodes(dnList.size());
Review Comment:
From the Metrics given in this PR
https://github.com/apache/ozone/pull/7249#issue-2554897610, the overloaded DNs
were not a rare case, because before applying this patch, they EC key deletion
was very slow, which should be cause by the large number of overloaded DNs. So
I think we can keep this Metric.
By default this Metric be updated per minute, as long as the acquisition
Metric rate is less than this interval, then we can monitor the overloaded DNs
count correctly.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
