sumitagrawl commented on code in PR #7249:
URL: https://github.com/apache/ozone/pull/7249#discussion_r1800727446
##########
hadoop-hdds/server-scm/src/main/java/org/apache/hadoop/hdds/scm/block/DeletedBlockLogImpl.java:
##########
@@ -369,12 +372,13 @@ public DatanodeDeletedBlockTransactions getTransactions(
if (checkInadequateReplica(replicas, txn)) {
continue;
}
+ metrics.setNumBlockDeletionTransactionDataNodes(dnList.size());
Review Comment:
@xichen01 Since dnList.size() is constant for the iteration, setting this
inside loop of getTransaction() may not be redundant. We can move out to place
where final dnList is prepared.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
