sumitagrawl commented on code in PR #7249:
URL: https://github.com/apache/ozone/pull/7249#discussion_r1803329032
##########
hadoop-hdds/server-scm/src/main/java/org/apache/hadoop/hdds/scm/block/DeletedBlockLogImpl.java:
##########
@@ -358,23 +363,24 @@ public DatanodeDeletedBlockTransactions getTransactions(
// HDDS-7126. When container is under replicated, it is possible
// that container is deleted, but transactions are not deleted.
if (containerManager.getContainer(id).isDeleted()) {
- LOG.warn("Container: " + id + " was deleted for the " +
- "transaction: " + txn);
+ LOG.warn("Container: {} was deleted for the " +
+ "transaction: {}.", id, txn);
txIDs.add(txn.getTxID());
} else if (txn.getCount() > -1 && txn.getCount() <= maxRetry
&& !containerManager.getContainer(id).isOpen()) {
Set<ContainerReplica> replicas = containerManager
.getContainerReplicas(
ContainerID.valueOf(txn.getContainerID()));
- if (checkInadequateReplica(replicas, txn)) {
+ if (checkInadequateReplica(replicas, txn, dnList)) {
Review Comment:
transaction is also skipped for openContainer, and for transaction crossed
maxRetry. Since the metric is generic, it should consider this case, adding as
else to capture this
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
