ArafatKhan2198 commented on PR #7213: URL: https://github.com/apache/ozone/pull/7213#issuecomment-2418668928
### Testing out the Dynamic Upgrade action handling for Recon Schema Versioning --- For testing purposes, I introduced another upgrade action type called `TEST_ACTION` alongside `AUTO_FINALIZE` for the feature named `FEATURE_3`. For this feature, I assigned two upgrade actions—one of type `AUTO_FINALIZE` and the other of type `TEST_ACTION`. These are only used for testing and will be removed later. When I started up Recon, I observed the following log outputs: ``` [main] INFO upgrade.ReconLayoutVersionManager: Current MLV: 0. SLV: 3. Checking features for registration... [main] INFO upgrade.ReconLayoutVersionManager: Feature FEATURE_1 (version 1) is registered for finalization. [main] INFO upgrade.ReconLayoutVersionManager: Feature FEATURE_2 (version 2) is registered for finalization. [main] INFO upgrade.ReconLayoutVersionManager: Feature FEATURE_3 (version 3) is registered for finalization. [main] INFO upgrade.Feature1UpgradeActionForAutoFinalise: Executing Feature 1 upgrade script for action type AUTO_FINALIZE... [main] INFO recon.ReconSchemaVersionTableManager: Inserted new schema version '1'. [main] INFO upgrade.ReconLayoutVersionManager: MLV updated to: 1 [main] INFO upgrade.ReconLayoutVersionManager: Feature 1 finalized successfully. [main] INFO upgrade.Feature2UpgradeActionForAutoFinalise: Executing Feature 2 upgrade script for action type AUTO_FINALIZE... [main] INFO recon.ReconSchemaVersionTableManager: Updated schema version to '2'. [main] INFO upgrade.ReconLayoutVersionManager: MLV updated to: 2 [main] INFO upgrade.ReconLayoutVersionManager: Feature 2 finalized successfully. [main] INFO upgrade.Feature3UpgradeActionForAutoFinalise: Executing Feature 3 upgrade script for action type AUTO_FINALIZE... [main] INFO recon.ReconSchemaVersionTableManager: Updated schema version to '3'. [main] INFO upgrade.ReconLayoutVersionManager: MLV updated to: 3 [main] INFO upgrade.ReconLayoutVersionManager: Feature 3 finalized successfully. ``` Currently, for Recon, we've decided that upgrade actions will be autofinalized. This means that only actions marked with the type `AUTO_FINALIZE` are selected and executed. In the case of `FEATURE_3`, the upgrade action of type `TEST_ACTION` was not executed at all. This is because the code is specifically designed to execute only `AUTO_FINALIZE` upgrade actions, and thus, there is no log output like, "Executing Feature 3 upgrade script for action type TEST_ACTION." This confirms that annotation-based upgrade action execution is working as expected, as only the appropriate actions (in this case, `AUTO_FINALIZE`) are executed while others are ignored. @sumitagrawl @devmadhuu please go through this -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
