fapifta commented on code in PR #6932: URL: https://github.com/apache/ozone/pull/6932#discussion_r1807128579
########## hadoop-hdds/annotations/src/main/java/org/apache/ozone/annotations/OmRequestFeatureValidatorProcessor.java: ########## Review Comment: Sorry I missed this reply... The goal of the annotation processor is to signal erroneously annotated methods at compile time, so if this is testable properly, then I would prefer to cause a compile time error, as runtime issues may or may not be detected in the future, especially if you look at our compat tests, that are not really testing whether the actual validators are properly applied. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
