fapifta commented on code in PR #6932: URL: https://github.com/apache/ozone/pull/6932#discussion_r1807132273
########## hadoop-ozone/ozone-manager/src/test/java/org/apache/hadoop/ozone/om/request/validation/TestOMValidatorProcessor.java: ########## Review Comment: You can not predict any validation that a future version may need, so it is kind of nonsensical to allow or at least to use FUTURE_VERSION in the annotation until we figure out time travel. FUTURE_VERSION is a technical value just to indicate that the server side does not know what the supplied client version mean. I probably am fine allowing FUTURE_VERSION in the annotation, but defining any method annotated with a FUTURE_VERSION is clearly a misunderstanding, if we can I would prevent ourselves against such a misunderstanding. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
