errose28 commented on PR #7329: URL: https://github.com/apache/ozone/pull/7329#issuecomment-2429839752
I don't think [this thread](https://github.com/apache/ozone/pull/7329#discussion_r1808118835) was really resolved and I have the same question. Why are we having OM reach inside Ratis to manage its retry cache. Shouldn't Ratis handle this for us? > The check for retry cache happens after preExecute() in submitRequestToRatis() > ... > This method is executed by Hadoop RPC server handler (note that client sends requests to OM via Hadoop RPC, and the leader creates a raft request out of the Hadoop RPC request) Pre-execute should not depend on the state machine, it should only operate on the content of the message. If a duplicate rename request is failing in the pre-execute, we should investigate why that is. Is it coming from the ACL checks which were moved there in HDDS-9388? I would only expect this to a problem for native ACLs, but I believe Ranger ACLs were being used in this test. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
