errose28 commented on PR #7329: URL: https://github.com/apache/ozone/pull/7329#issuecomment-2433179460
> first of all the preExecute() doesn't specify what's expected to happen in there. So it can cause confusion for OMClientRequest implementations. Some kind of contract test would be great too. This is a broader problem for the entire OM request flow. There's so many requirements about what must be done where it is very difficult to enforce. I hope the work Sumit is doing to simplify the request flow will be the ultimate solution. > I thought about fixing this request handler's preExecute() but I fear other preExecute() also have the similar problem and it's hard to catch them all, so I thought it's better to do a catch-all fix. I agree, any non-idempotent operation will have this problem. My question comes though because I don't see an actual RCA on the issue, as in what part of the request code the issue actually came from. My theory is ACLs but I don't see enough stack trace info to validate this. I think we need this information to assess whether we are actually fixing this in the best way. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
