devabhishekpal commented on code in PR #7268:
URL: https://github.com/apache/ozone/pull/7268#discussion_r1812062647
##########
hadoop-ozone/common/src/main/java/org/apache/hadoop/ozone/om/ha/HadoopRpcOMFailoverProxyProvider.java:
##########
@@ -75,8 +74,7 @@ public HadoopRpcOMFailoverProxyProvider(ConfigurationSource
configuration,
UserGroupInformation ugi,
String omServiceId,
Class<T> protocol) throws IOException {
- super(configuration, omServiceId, protocol);
- this.ugi = ugi;
+ super(configuration, ugi, omServiceId, protocol);
this.omVersion = RPC.getProtocolVersion(protocol);
Review Comment:
Addressed in
[c52deae](https://github.com/apache/ozone/pull/7268/commits/c52deaec7d51ec9adea755d75d83e82bcdd74e3d)
##########
hadoop-ozone/common/src/main/java/org/apache/hadoop/ozone/om/ha/GrpcOMFailoverProxyProvider.java:
##########
@@ -59,10 +63,14 @@ public class GrpcOMFailoverProxyProvider<T> extends
public static final Logger LOG =
LoggerFactory.getLogger(GrpcOMFailoverProxyProvider.class);
+ private final long protocolVer;
+
public GrpcOMFailoverProxyProvider(ConfigurationSource configuration,
+ UserGroupInformation ugi,
String omServiceId,
Class<T> protocol) throws IOException {
- super(configuration, omServiceId, protocol);
+ super(configuration, ugi, omServiceId, protocol);
+ this.protocolVer = RPC.getProtocolVersion(protocol);
Review Comment:
Addressed in
[c52deae](https://github.com/apache/ozone/pull/7268/commits/c52deaec7d51ec9adea755d75d83e82bcdd74e3d)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
