devabhishekpal commented on code in PR #7268:
URL: https://github.com/apache/ozone/pull/7268#discussion_r1812082531
##########
hadoop-ozone/common/src/main/java/org/apache/hadoop/ozone/om/ha/GrpcOMFailoverProxyProvider.java:
##########
@@ -116,9 +126,35 @@ protected void loadOMClientConfigs(ConfigurationSource
config, String omSvcId)
private T createOMProxy() throws IOException {
InetSocketAddress addr = new InetSocketAddress(0);
+ return createOmProxy(addr);
+ }
+
+ /**
+ * Get the protocol proxy for provided address.
+ * @param address An instance of {@link InetSocketAddress} which contains
the address to connect
+ * @return the proxy connection to the address and the set of methods
supported by the server at the address
+ * @throws IOException if any error occurs while trying to get the proxy
+ */
+ private T createOmProxy(InetSocketAddress address) throws IOException {
Configuration hadoopConf =
LegacyHadoopConfigurationSource.asHadoopConfiguration(getConf());
- return (T) RPC.getProxy(getInterface(), 0, addr, hadoopConf);
+
+ // TODO: Post upgrade to Protobuf 3.x we need to use ProtobufRpcEngine2
+ RPC.setProtocolEngine(hadoopConf, getInterface(), ProtobufRpcEngine.class);
+
+ // Ensure we do not attempt retry on the same OM in case of exceptions
+ RetryPolicy connectionRetryPolicy =
RetryPolicies.failoverOnNetworkException(0);
+
+ return (T) RPC.getProtocolProxy(
+ getInterface(),
+ protocolVer,
+ address,
+ ugi,
+ hadoopConf,
+ NetUtils.getDefaultSocketFactory(hadoopConf),
+ (int) OmUtils.getOMClientRpcTimeOut(getConf()),
+ connectionRetryPolicy
+ ).getProxy();
Review Comment:
Yup, I have removed those as well in the new commit
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
