pyttel commented on code in PR #9:
URL: https://github.com/apache/ozone-helm-charts/pull/9#discussion_r1813497368
##########
charts/ozone/templates/ozone-configmap.yaml:
##########
@@ -19,7 +19,7 @@
apiVersion: v1
kind: ConfigMap
metadata:
- name: {{ .Release.Name }}
+ name: {{ .Release.Name }}-ozone
Review Comment:
I changed it because I used ozone helm chart as dependency chart. When using
plain release name, I got a conflict with an already existing configMap of the
main chart with `{{ .Release.Name }}`. This could avoid such conflicts and, in
my opinion, this can help to identify the belonging of the configMap faster in
such aggregated charts. But it is definitely not needed. I can change this back
if you prefer it :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
