devmadhuu commented on code in PR #7358:
URL: https://github.com/apache/ozone/pull/7358#discussion_r1820100050
##########
hadoop-ozone/recon/src/main/resources/webapps/recon/ozone-recon-web/src/app.tsx:
##########
@@ -32,22 +32,23 @@ import classNames from 'classnames';
import Loader from '@/v2/components/loader/loader';
import './app.less';
+import NotFound from '@/v2/pages/notFound/notFound';
Review Comment:
So this is new page for `notFound 404`, but if it is imported here, how it
is being used across Recon for all APIs in generic way ?
##########
hadoop-ozone/recon/src/main/resources/webapps/recon/ozone-recon-web/src/app.tsx:
##########
@@ -56,48 +57,51 @@ class App extends React.Component<Record<string, object>,
IAppState> {
};
render() {
- const { collapsed, enableNewUI } = this.state;
+ const { collapsed, enableOldUI } = this.state;
const layoutClass = classNames('content-layout', { 'sidebar-collapsed':
collapsed });
return (
<Router>
<Layout style={{ minHeight: '100vh' }}>
{
- (enableNewUI)
- ? <NavBarV2 collapsed={collapsed} onCollapse={this.onCollapse} />
- : <NavBar collapsed={collapsed} onCollapse={this.onCollapse} />
+ (enableOldUI)
+ ? <NavBar collapsed={collapsed} onCollapse={this.onCollapse} />
+ : <NavBarV2 collapsed={collapsed} onCollapse={this.onCollapse} />
}
<Layout className={layoutClass}>
<Header>
<div style={{ margin: '16px 0', display: 'flex', justifyContent:
'space-between' }}>
- {(enableNewUI) ? <BreadcrumbsV2 /> : <Breadcrumbs />}
+ {(enableOldUI) ? <Breadcrumbs /> : <BreadcrumbsV2 />}
<AntDSwitch
- disabled={true}
- checkedChildren={<div style={{ paddingLeft: '2px' }}>New
UI</div>}
+ unCheckedChildren={<div style={{ paddingRight: '2px' }}>UI
v2</div>}
Review Comment:
Its better to rename labels shown to users as old and new UI as "Switch to
Old UI" and "Switch to New UI"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
