devabhishekpal commented on code in PR #7358: URL: https://github.com/apache/ozone/pull/7358#discussion_r1820123345
########## hadoop-ozone/recon/src/main/resources/webapps/recon/ozone-recon-web/src/app.tsx: ########## @@ -32,22 +32,23 @@ import classNames from 'classnames'; import Loader from '@/v2/components/loader/loader'; import './app.less'; +import NotFound from '@/v2/pages/notFound/notFound'; Review Comment: So this 404 page is only shown on routing issues, i.e if the user tries to visit a page that is not present in the UI. But for backend/API calls in case of a 404 there is a popup notification which shows the error details. This is because the backend calls should not hinder current usage and in case some API doesn't exist we should notify the user and silently handle the error. This 404 is only shown when the user navigates to a page that doesn't exist -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
