adoroszlai commented on code in PR #7440:
URL: https://github.com/apache/ozone/pull/7440#discussion_r1845545421
##########
hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/OmMetadataReader.java:
##########
Review Comment:
nit: This file has only whitespace changes.
##########
hadoop-ozone/client/src/main/java/org/apache/hadoop/ozone/client/rpc/RpcClient.java:
##########
@@ -2311,6 +2311,22 @@ public List<OzoneFileStatus> listStatus(String
volumeName, String bucketName,
allowPartialPrefixes);
}
+ @Override
+ public List<OzoneFileStatusLight> listStatusLight(String volumeName, String
bucketName, String keyName,
+ boolean recursive, String startKey, long numEntries) throws IOException {
+ OmKeyArgs keyArgs = prepareOmKeyArgs(volumeName, bucketName, keyName);
+ if (omVersion.compareTo(OzoneManagerVersion.LIGHTWEIGHT_LIST_STATUS) >= 0)
{
+ return ozoneManagerClient.listStatusLight(keyArgs, recursive, startKey,
+ numEntries);
Review Comment:
`OzoneManagerVersion.LIGHTWEIGHT_LIST_STATUS` is an existing version, added
in HDDS-11414. The method being called is new in this PR:
https://github.com/apache/ozone/blob/bd264b5d415466743cf25825f9d4d75d1af26143/hadoop-ozone/common/src/main/java/org/apache/hadoop/ozone/om/protocol/OzoneManagerProtocol.java#L1000-L1001
So this is not compatible with versions of Ozone Manager between these
commits (8ca33c718b and the one that will precede this on `master` when merged).
My suggestion:
- remove the new method from `OzoneManagerProtocol` and its implementations,
- call the existing method here:
```suggestion
return ozoneManagerClient.listStatusLight(keyArgs, recursive, startKey,
numEntries, false);
```
(It's not worth adding yet another `OzoneManagerVersion` constant, since the
new method is a subset of the existing.)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
