adoroszlai commented on code in PR #7440:
URL: https://github.com/apache/ozone/pull/7440#discussion_r1845606959
##########
hadoop-ozone/client/src/main/java/org/apache/hadoop/ozone/client/rpc/RpcClient.java:
##########
@@ -2311,6 +2311,22 @@ public List<OzoneFileStatus> listStatus(String
volumeName, String bucketName,
allowPartialPrefixes);
}
+ @Override
+ public List<OzoneFileStatusLight> listStatusLight(String volumeName, String
bucketName, String keyName,
+ boolean recursive, String startKey, long numEntries) throws IOException {
+ OmKeyArgs keyArgs = prepareOmKeyArgs(volumeName, bucketName, keyName);
+ if (omVersion.compareTo(OzoneManagerVersion.LIGHTWEIGHT_LIST_STATUS) >= 0)
{
+ return ozoneManagerClient.listStatusLight(keyArgs, recursive, startKey,
+ numEntries);
Review Comment:
Sorry, I was wrong, it works, because client never calls the new method on
the server. `OzoneManagerProtocolClientSideTranslatorPB` does the trick and
calls the old method, somewhat like I suggested.
Still, I think removing the unused method would improve clarity.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
