sodonnel commented on code in PR #7402:
URL: https://github.com/apache/ozone/pull/7402#discussion_r1845652019
##########
hadoop-hdds/container-service/src/main/java/org/apache/hadoop/ozone/container/common/impl/ContainerSet.java:
##########
@@ -65,10 +69,19 @@ public class ContainerSet implements Iterable<Container<?>>
{
new ConcurrentSkipListMap<>();
private Clock clock;
private long recoveringTimeout;
+ private final Table<Long, State> containerIdsTable;
+
+ public ContainerSet(Table<Long, State> continerIdsTable, long
recoveringTimeout) {
Review Comment:
If we kept the existing constructor and marked it a visibleForTest, then
make it create a "test version" of this class, would it reduce all the test
files that need to be changed?
```
public ContainerSet(long recoveringTimeout) {
this(ImMemoryTable, recoveringTimeout, true / false);
}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
