swamirishi commented on PR #7402: URL: https://github.com/apache/ozone/pull/7402#issuecomment-2482944743
> Where does `continerIdsTable` get populated with the pre-existing list of containers on the datanode after the first restart when this code change is added? Maybe I have missed, but I cannot see where it happens. Does it need to get populated, so it contains the complete list of containers and hence is able to detect future failures? It happens as part of the ContainerReader which calls the addContainer in the containerSet https://github.com/apache/ozone/blob/f22f0d172b552359f9cfbd60ddde3a4bdd66c8fd/hadoop-hdds/container-service/src/main/java/org/apache/hadoop/ozone/container/ozoneimpl/ContainerReader.java#L216-L232 After the containerReader run: we build the missingContainerSet by reading through the existing values in the DB https://github.com/apache/ozone/blob/5b3d27aac581d9b79b13cf7d22f378cbf6950575/hadoop-hdds/container-service/src/main/java/org/apache/hadoop/ozone/container/ozoneimpl/OzoneContainer.java#L331-L352 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
