swamirishi commented on code in PR #7402:
URL: https://github.com/apache/ozone/pull/7402#discussion_r1847194519
##########
hadoop-ozone/tools/src/main/java/org/apache/hadoop/ozone/freon/ClosedContainerReplicator.java:
##########
@@ -82,66 +84,74 @@ public class ClosedContainerReplicator extends
BaseFreonGenerator implements
private ContainerReplicator replicator;
private Timer timer;
+ private ReferenceCountedHandle<MasterVolumeMetadataStore>
masterVolumeMetadataStoreReferenceCountedDB;
private List<ReplicationTask> replicationTasks;
@Override
public Void call() throws Exception {
- OzoneConfiguration conf = createOzoneConfiguration();
+ try {
+ OzoneConfiguration conf = createOzoneConfiguration();
- final Collection<String> datanodeStorageDirs =
- HddsServerUtil.getDatanodeStorageDirs(conf);
+ final Collection<String> datanodeStorageDirs =
+ HddsServerUtil.getDatanodeStorageDirs(conf);
Review Comment:
done
##########
hadoop-hdds/framework/src/main/java/org/apache/hadoop/hdds/utils/db/DBTestUtils.java:
##########
@@ -0,0 +1,142 @@
+package org.apache.hadoop.hdds.utils.db;
+
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ *
+ */
+
+import org.apache.hadoop.hdds.utils.MetadataKeyFilters;
+
+import java.io.File;
+import java.io.IOException;
+import java.util.List;
+import java.util.Map;
+import java.util.concurrent.ConcurrentHashMap;
+
+/**
+ * Util class for mocking DB interactions happening in various tests.
+ */
+public final class DBTestUtils {
+
+ private DBTestUtils() {
+
+ }
+
+ public static <KEY, VALUE> Table<KEY, VALUE> getInMemoryTableForTest() {
+ return new Table<KEY, VALUE>() {
+ private final Map<KEY, VALUE> map = new ConcurrentHashMap<>();
Review Comment:
done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
