ivandika3 commented on code in PR #7459:
URL: https://github.com/apache/ozone/pull/7459#discussion_r1853177202
##########
hadoop-hdds/server-scm/src/main/java/org/apache/hadoop/hdds/scm/container/replication/LegacyReplicationManager.java:
##########
@@ -333,6 +341,11 @@ public LegacyReplicationManager(final ConfigurationSource
conf,
.setDBTransactionBuffer(scmhaManager.getDBTransactionBuffer())
.setRatisServer(scmhaManager.getRatisServer())
.setMoveTable(moveTable).build();
+
+ inflightMoveScannerExecutor = Executors.newSingleThreadExecutor(
Review Comment:
Thanks for the review. Let me think about it. My current idea is to shutdown
the `ExecutorService` when stopping the `ReplicationManager` and reinitializing
the `ExecutorService` in the `start`. Let me write more extensive tests to
check this since `notifyStatusChanged` is run in Ratis and if any uncaught
exception is thrown it might stop the whole `StateMachine`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
