ivandika3 commented on code in PR #7459:
URL: https://github.com/apache/ozone/pull/7459#discussion_r1853258152
##########
hadoop-hdds/server-scm/src/main/java/org/apache/hadoop/hdds/scm/container/replication/LegacyReplicationManager.java:
##########
@@ -333,6 +341,11 @@ public LegacyReplicationManager(final ConfigurationSource
conf,
.setDBTransactionBuffer(scmhaManager.getDBTransactionBuffer())
.setRatisServer(scmhaManager.getRatisServer())
.setMoveTable(moveTable).build();
+
+ inflightMoveScannerExecutor = Executors.newSingleThreadExecutor(
Review Comment:
I think another issue is that `ReplicationManager#stop` will not replicate
it to the other SCMs. Meaning that one SCM might have `running` flag `false`,
while the other has `running` flag `true`. If for example we transfer
leadership from the one with stopped RM to the one with running RM, the
`notifyStatusChanged` will still trigger the `inflightMoveScannerExecutor`.
In my opinion, for now we can let `inflightMoveScannerExecutor` to send some
replicate commands even if it's stopped.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
