xichen01 commented on code in PR #7467:
URL: https://github.com/apache/ozone/pull/7467#discussion_r1856937644
##########
hadoop-ozone/integration-test/src/test/java/org/apache/hadoop/ozone/debug/TestLDBCli.java:
##########
@@ -384,7 +435,7 @@ private void assertContents(Map<String, ?> expected, String
actualStr)
* @param tableName table name
* @param schemaV3 set to true for SchemaV3. applicable to block_data table
*/
- private void prepareTable(String tableName, boolean schemaV3)
+ private void prepareTable(String tableName, boolean schemaV3, int...
recordsCount)
Review Comment:
I think just `void prepareTable(String tableName, boolean schemaV3, int
recordsCount)` is OK, we can pass `5` for other method (like
`prepareTable(KEY_TABLE, true, 5)`).
##########
hadoop-ozone/tools/src/main/java/org/apache/hadoop/ozone/debug/DBScanner.java:
##########
@@ -240,11 +250,31 @@ private boolean displayTable(ManagedRocksIterator
iterator,
return displayTable(iterator, dbColumnFamilyDef, out(), schemaV3);
}
+ // If there are no parent directories, create them
+ if (recordsPerFile > 0) {
Review Comment:
We can automatically create parent directory for both recordsPerFile > 0 and
recordsPerFile == 0, current, not give the `--max-records-per-file` the parent
directory will not be created automatically.
Maybe just need remove the `if`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
