jianghuazhu commented on code in PR #7467:
URL: https://github.com/apache/ozone/pull/7467#discussion_r1857729713


##########
hadoop-ozone/integration-test/src/test/java/org/apache/hadoop/ozone/debug/TestLDBCli.java:
##########
@@ -384,7 +435,7 @@ private void assertContents(Map<String, ?> expected, String 
actualStr)
    * @param tableName table name
    * @param schemaV3 set to true for SchemaV3. applicable to block_data table
    */
-  private void prepareTable(String tableName, boolean schemaV3)
+  private void prepareTable(String tableName, boolean schemaV3, int... 
recordsCount)

Review Comment:
   When constructing the `BLOCK_DATA` dataset, `containerCount` and 
`blockCount` are needed. They can be shared with `recordsCount`, what do you 
think? @xichen01 
   ```
         final int containerCount = 2;
         final int blockCount = 2;
         int blockId = 1;
         for (int cid = 1; cid <= containerCount; cid++) {
           for (int blockIdx = 1; blockIdx <= blockCount; blockIdx++, 
blockId++) {
    ......
   }
   }
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to