JingsongLi commented on code in PR #829:
URL: https://github.com/apache/incubator-paimon/pull/829#discussion_r1157022094
##########
paimon-core/src/main/java/org/apache/paimon/table/AbstractFileStoreTable.java:
##########
@@ -106,16 +105,10 @@ public InnerStreamTableScan newStreamScan() {
protected abstract FileStoreTable copy(TableSchema newTableSchema);
+ // sometimes we have to change some Immutable options to implement
features, so don't check it
@Override
public FileStoreTable copy(Map<String, String> dynamicOptions) {
- // check option is not immutable
Map<String, String> options = new HashMap<>(tableSchema.options());
- dynamicOptions.forEach(
Review Comment:
don't remove this, create an another internal method.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
