JingsongLi commented on code in PR #829:
URL: https://github.com/apache/incubator-paimon/pull/829#discussion_r1159213969


##########
paimon-flink/paimon-flink-common/src/main/java/org/apache/paimon/flink/action/ActionBase.java:
##########
@@ -147,4 +148,17 @@ protected void batchSink(DataStream<RowData> dataStream) {
 
         TableEnvironmentUtils.executeInternal(tEnv, transformations, 
sinkIdentifierNames);
     }
+
+    /**
+     * The {@link CoreOptions.MergeEngine}s will process -U/-D records in 
different ways, but we
+     * want these records to be sunk directly. This method is a workaround. 
Actions that may produce
+     * -U/-D records can disable merge engine settings when running.
+     */
+    protected void resetMergeEngine() {

Review Comment:
   maybe not just reset merge engine, we need to force compaction too.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to