carp84 commented on PR #1067: URL: https://github.com/apache/incubator-paimon/pull/1067#issuecomment-1537338118
About legal checking, aside from the changes made in this PR, please also check the below parts: 1. In the `paimon-codegen/src/main/resources/META-INF/NOTICE` file, it mentions `licenses/LICENSE.scala` which seems to be missing. 2. In the `paimon-common/src/main/resources/META-INF/NOTICE` file, it mentions dependency on [janino](https://github.com/janino-compiler/janino/blob/master/LICENSE) which seems to be missing in `paimon-common/src/main/resources/META-INF/licenses`(No LICENSE.janino file found) 3. In the `paimon-filesystems/paimon-oss-impl/src/main/resources/META-INF/NOTICE` file, it mentions dependency on [jacoco](https://github.com/jacoco/jacoco/blob/master/LICENSE.md) which seems to be missing in `paimon-filesystems/paimon-oss-impl/src/main/resources/META-INF/licenses` 4. In the `paimon-filesystems/paimon-s3-impl/src/main/resources/META-INF/NOTICE` file, it mentions many dependencies but only license files for `re2j`, `stax2api` and `jaxb` appear in `paimon-filesystems/paimon-s3-impl/src/main/resources/META-INF/licenses` 5. In the `paimon-filesystems/paimon-hadoop-shaded/src/main/resources/META-INF/NOTICE` file, it mentions more dependencies than what's presenting in `paimon-filesystems/paimon-hadoop-shaded/src/main/resources/META-INF/licenses` 6. In the `paimon-format/src/main/resources/META-INF/NOTICE` file, it mentions [protobuf-java](https://github.com/protocolbuffers/protobuf/blob/main/LICENSE) while there's no license file presented I suggest to check whether we are really bundling the dependencies as recorded in the nested NOTICE file under different sub-modules, and make fix accordingly (removing the dependency from NOTICE file or adding license file for dependencies) PS. I caught the above issues by running the `grep -R "Copyright" ./*` command in the source package of 0.4.0-rc3 and checking the outputs. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
