carp84 commented on code in PR #1067: URL: https://github.com/apache/incubator-paimon/pull/1067#discussion_r1188051907
########## licenses/LICENSE.aws: ########## Review Comment: For dependencies with standard ALv2, we don't need to duplicate the license content according to the instructions [here](https://infra.apache.org/licensing-howto.html#alv2-dep). The same applies to `LICENSE.paldb` ########## paimon-codegen/src/main/resources/META-INF/licenses/LICENSE.scala: ########## Review Comment: It seems that this file is slightly different from the [LICENSE](https://github.com/scala/scala/blob/v2.12.7/LICENSE) file in scala 2.12.7 release, especially on the copyright year part. btw, scala used BSD 3-clause license before Dec. 2018 but has [changed to ALv2](https://www.scala-lang.org/news/license-change.html) now, we may notice to update the license file if change the dependency version in future (2.12.7 was released in Sep. 2018 so BSD-3 still). ########## paimon-filesystems/paimon-oss-impl/src/main/resources/META-INF/licenses/LICENSE.eclipse: ########## Review Comment: I think we should use the [license file under jacoco 0.8.5 release](https://github.com/jacoco/jacoco/blob/v0.8.5/LICENSE.md) instead, which includes the copyright content. ########## paimon-filesystems/paimon-hadoop-shaded/src/main/resources/META-INF/licenses/LICENSE.checker-framework: ########## Review Comment: We should use the [license under the checker-qual module](https://github.com/typetools/checker-framework/blob/master/checker-qual/LICENSE.txt) instead, which is an MIT license. The license of the whole checker-framework project is GNU GPL2 which is under [category-X](https://www.apache.org/legal/resolved.html#category-x) and is not permissive to use in ASF projects. Related, I suggest to rename this file as `LICENSE.checker-qual` (and update the reference in the NOTICE file accordingly) ########## paimon-filesystems/paimon-s3-impl/src/main/resources/META-INF/licenses/LICENSE.checker-framework: ########## Review Comment: Ditto, please use the checker-qual MIT license instead. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
