legendtkl commented on code in PR #1434:
URL: https://github.com/apache/incubator-paimon/pull/1434#discussion_r1241597352
##########
paimon-flink/paimon-flink-common/src/main/java/org/apache/paimon/flink/sink/FlinkTableSink.java:
##########
@@ -135,4 +233,50 @@ public RowLevelDeleteInfo applyRowLevelDelete(
table.getClass().getName()));
}
}
+
+ private boolean shouldPushdownDeleteFilter(Predicate predicate, int
predicateSize) {
Review Comment:
hi, @JingsongLi , is the visitor too complicated for this to implement all
the method visitXXX of interface FunctionVisitor?
When the filter is `where id=1 or id=2 or id=3` or `where id in (1,2,3)`, it
will be converted to
```sql
compound(OR)
/ \
compound(OR) leaf(Equal, id, 1)
/ \
leaf(Equal,id,2) leaf(Equal,id,3)
```
We just need to check all the compoundFilter's func is OR and all the
leafFilter's func is Equal and field is in primary keys.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
