legendtkl commented on code in PR #1434:
URL: https://github.com/apache/incubator-paimon/pull/1434#discussion_r1242281920
##########
paimon-flink/paimon-flink-common/src/main/java/org/apache/paimon/flink/sink/FlinkTableSink.java:
##########
@@ -135,4 +233,50 @@ public RowLevelDeleteInfo applyRowLevelDelete(
table.getClass().getName()));
}
}
+
+ private boolean shouldPushdownDeleteFilter(Predicate predicate, int
predicateSize) {
Review Comment:
@JingsongLi the filter `where id in (5, 6, 7, 8)` seems to be convert to
the following predicate, other than IN. Let's handle it as CompoundPredicate(OR)
* flink: CallExpression(or(or(or(equals(id, 5), equals(id, 6)), equals(id,
7)), equals(id, 8)))
* paimon: CompoundPredicate(OR, children)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]