JingsongLi commented on code in PR #1678:
URL: https://github.com/apache/incubator-paimon/pull/1678#discussion_r1280024092
##########
paimon-common/src/main/java/org/apache/paimon/types/DataField.java:
##########
@@ -76,6 +77,11 @@ public DataType type() {
return type;
}
+ @VisibleForTesting
Review Comment:
A newId method looks good to me.
We can just remove `VisibleForTesting`. (Public class should not have public
VisibleForTesting method)
##########
paimon-core/src/main/java/org/apache/paimon/AbstractFileStore.java:
##########
@@ -142,6 +142,11 @@ public CoreOptions options() {
return options;
}
+ @Override
+ public boolean mergeSchema(RowType rowType, Boolean allowExplicitCast) {
Review Comment:
boolean instead of Boolean?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
