[GitHub] [incubator-paimon] Alibaba-HZY commented on a diff in pull request #1837: [hive]hive create table should force primary key not null

Thu, 17 Aug 2023 01:25:53 -0700 


Alibaba-HZY commented on code in PR #1837:
URL: https://github.com/apache/incubator-paimon/pull/1837#discussion_r1296857725


##########
paimon-core/src/main/java/org/apache/paimon/schema/SchemaManager.java:
##########
@@ -146,7 +146,23 @@ public TableSchema createTable(Schema schema) throws 
Exception {
                 }
                 options.remove(CoreOptions.PRIMARY_KEY.key());
             }
-
+            List<String> finalPrimaryKeys = primaryKeys;
+            fields =

Review Comment:
   when hive create table primary key  is created by 
   
![image](https://github.com/apache/incubator-paimon/assets/48040205/106a412e-4743-4ca9-b799-489b36570645)
   is not from Schema.normalizeFields



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to