liming30 commented on PR #1823: URL: https://github.com/apache/incubator-paimon/pull/1823#issuecomment-1684020208
@JingsongLi Thanks for your suggestion, I refactored the implementation of the code: use a single thread executor to expire asynchronously in `TableCommitImpl`, use a threadpool to delete files concurrently in `FileDeletionBase` and wait for the result of the deletion synchronously. I kept the `snapshot.expire.execution-mode` configuration option and set it to `sync` by default for two reasons: 1. After adding the ability to delete files concurrently, if the production speed is still lower than the deletion speed, using `sync` as the default option can help users perceive this and make adjustments. 2. A large number of tests assume that `expire` will be completed at the end of the `commit` method. If the default setting is `async`, it may increase the cost of writing test code. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
