leaves12138 commented on code in PR #2858:
URL: https://github.com/apache/paimon/pull/2858#discussion_r1591770324


##########
paimon-core/src/main/java/org/apache/paimon/append/AppendOnlyCompactionTask.java:
##########
@@ -39,13 +40,22 @@ public class AppendOnlyCompactionTask {
     private final List<DataFileMeta> compactBefore;
     private final List<DataFileMeta> compactAfter;
 
+    private final Identifier tableIdentifier;
+
     public AppendOnlyCompactionTask(BinaryRow partition, List<DataFileMeta> 
files) {
+        this(partition, files, Identifier.EMPTY);
+    }
+
+    public AppendOnlyCompactionTask(
+            BinaryRow partition, List<DataFileMeta> files, Identifier 
identifier) {

Review Comment:
   We can just put string in `MultiTableAppendOnlyCompactionTask`, then we can 
remove `IdentifierSerializer`.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to