leaves12138 commented on code in PR #2858: URL: https://github.com/apache/paimon/pull/2858#discussion_r1591865881
########## paimon-flink/paimon-flink-common/src/main/java/org/apache/paimon/flink/compact/CompactionFileScanner.java: ########## @@ -0,0 +1,50 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.paimon.flink.compact; + +import org.apache.paimon.append.AppendOnlyCompactionTask; +import org.apache.paimon.table.source.Split; + +import org.apache.flink.streaming.api.functions.source.SourceFunction; + +import java.util.concurrent.atomic.AtomicBoolean; + +/** + * The class is response for scanning the file which need compaction. + * + * @param <T> the result of scanning file : + * <ol> + * <li>{@link Split} for the table with multi buckets, such as dynamic or fixed bucket table. + * <li>{@link AppendOnlyCompactionTask} for the table witch fixed single bucket ,such as + * unaware bucket table. + * </ol> + */ +public abstract class CompactionFileScanner<T> { + protected final AtomicBoolean isRunning; Review Comment: 可以在 CompactionFileScanner 和 AtomicBoolean 之间加个换行 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
