JingsongLi commented on code in PR #3383:
URL: https://github.com/apache/paimon/pull/3383#discussion_r1611047076
##########
paimon-core/src/main/java/org/apache/paimon/table/AbstractFileStoreTable.java:
##########
@@ -309,23 +308,14 @@ public TableCommitImpl newCommit(String commitUser) {
if (!options.writeOnly()) {
boolean changelogDecoupled = options.changelogLifecycleDecoupled();
ExpireSnapshots expireChangelog =
- newExpireChangelog()
- .maxDeletes(options.snapshotExpireLimit())
- .retainMin(options.changelogNumRetainMin())
- .retainMax(options.changelogNumRetainMax());
+
newExpireChangelog().config(options.expireConfig().build());
Review Comment:
reuse `options.expireConfig().build()`.
##########
paimon-core/src/main/java/org/apache/paimon/operation/FileDeletionBase.java:
##########
@@ -70,6 +73,13 @@ public abstract class FileDeletionBase {
protected final Map<BinaryRow, Set<Integer>> deletionBuckets;
protected final Executor ioExecutor;
+ protected boolean changelogDecoupled;
Review Comment:
changelogDecoupled who use this?
##########
paimon-core/src/main/java/org/apache/paimon/operation/FileDeletionBase.java:
##########
@@ -70,6 +73,13 @@ public abstract class FileDeletionBase {
protected final Map<BinaryRow, Set<Integer>> deletionBuckets;
protected final Executor ioExecutor;
+ protected boolean changelogDecoupled;
+
+ /** Used to record which tag is cached in tagged snapshots list. */
+ private int cachedTagIndex = -1;
+
+ /** Used to cache data files used by current tag. */
+ private final Map<BinaryRow, Map<Integer, Set<String>>> cachedTagDataFiles
= new HashMap<>();
Review Comment:
maybe we should introduce a `ExpireDeletion`? `TagDeletion` will not use
this field.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
