JingsongLi commented on code in PR #3383:
URL: https://github.com/apache/paimon/pull/3383#discussion_r1613228788
##########
paimon-core/src/main/java/org/apache/paimon/operation/TagDeletion.java:
##########
@@ -88,15 +91,21 @@ public void cleanUnusedManifests(Snapshot taggedSnapshot,
Set<String> skippingSe
cleanUnusedManifests(taggedSnapshot, skippingSet, false);
}
- public Predicate<ManifestEntry> dataFileSkipper(Snapshot fromSnapshot)
throws Exception {
- return dataFileSkipper(Collections.singletonList(fromSnapshot));
- }
+ protected Collection<ManifestEntry> readMergedDataFiles(Snapshot snapshot)
throws IOException {
Review Comment:
Duplicate codes?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
