wwj6591812 commented on code in PR #4345:
URL: https://github.com/apache/paimon/pull/4345#discussion_r1806138249
##########
paimon-core/src/main/java/org/apache/paimon/mergetree/compact/PartialUpdateMergeFunction.java:
##########
@@ -254,10 +253,9 @@ public KeyValue getResult() {
if (reused == null) {
reused = new KeyValue();
}
- if (currentDeleteRow) {
- return null;
- }
- return reused.replace(currentKey, latestSequenceNumber,
RowKind.INSERT, row);
+
+ RowKind rowKind = currentDeleteRow ? RowKind.DELETE : RowKind.INSERT;
Review Comment:
Why here don't return null could avoid NPE in :
"Caused by: java.util.concurrent.ExecutionException:
java.lang.NullPointerException
at java.util.concurrent.FutureTask.report(FutureTask.java:122)"
?
##########
paimon-core/src/main/java/org/apache/paimon/mergetree/compact/PartialUpdateMergeFunction.java:
##########
@@ -120,7 +120,6 @@ public void add(KeyValue kv) {
currentDeleteRow = true;
row = new GenericRow(getters.length);
}
- // ignore -U records
Review Comment:
Why delete this?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
