JingsongLi commented on code in PR #4345:
URL: https://github.com/apache/paimon/pull/4345#discussion_r1820093615
##########
paimon-flink/paimon-flink-common/src/test/java/org/apache/paimon/flink/PartialUpdateITCase.java:
##########
@@ -623,11 +623,12 @@ public void testIgnoreDelete(boolean localMerge) throws
Exception {
}
@Test
- public void testRemoveRecordOnDelete() {
+ public void testRemoveRecordOnDelete() throws Exception {
sql(
"CREATE TABLE remove_record_on_delete (pk INT PRIMARY KEY NOT
ENFORCED, a STRING, b STRING) WITH ("
+ " 'merge-engine' = 'partial-update',"
- + " 'partial-update.remove-record-on-delete' = 'true'"
+ + " 'partial-update.remove-record-on-delete' = 'true',"
+ + " 'changelog-producer' = 'lookup'"
Review Comment:
Can you add a new case for lookup?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
