Aitozi commented on code in PR #4393:
URL: https://github.com/apache/paimon/pull/4393#discussion_r1826525483


##########
docs/content/flink/quick-start.md:
##########
@@ -269,16 +269,27 @@ SELECT * FROM ....;
 ## Setting dynamic options
 
 When interacting with the Paimon table, table options can be tuned without 
changing the options in the catalog. Paimon will extract job-level dynamic 
options and take effect in the current session.
-The dynamic option's key format is 
`paimon.${catalogName}.${dbName}.${tableName}.${config_key}`. The 
catalogName/dbName/tableName can be `*`, which means matching all the specific 
parts.
+The dynamic table option's key format is 
`paimon.${catalogName}.${dbName}.${tableName}.${config_key}`. The 
catalogName/dbName/tableName can be `*`, which means matching all the specific 
parts. 
+The dynamic global option's key format is `paimon.${config_key}`. Global 
options will take effect for all the tables. Table options will override global 
options if there are conflicts.
 
 For example:
 
 ```sql
+-- set scan.timestamp-millis=1697018249001 for all tables

Review Comment:
   no `paimon` prefix will also work ?



##########
docs/content/spark/auxiliary.md:
##########
@@ -29,7 +29,9 @@ under the License.
 ## Set / Reset
 The SET command sets a property, returns the value of an existing property or 
returns all SQLConf properties with value and meaning.
 The RESET command resets runtime configurations specific to the current 
session which were set via the SET command to their default values.
-To set paimon configs specifically, you need add the `spark.paimon.` prefix.
+To set dynamic options globally, you need add the `spark.paimon.` prefix. You 
can also set dynamic table options at this format: 
+`paimon.spark.${dbName}.${tableName}.${config_key}`. The dbName/tableName can 
be `*`, which means matching all the specific parts. Dynamic 

Review Comment:
   `spark.paimon`?



##########
docs/content/spark/auxiliary.md:
##########
@@ -40,6 +42,19 @@ SET spark.paimon.file.block-size=512M;
 
 -- reset conf
 RESET spark.paimon.file.block-size;
+      
+-- set scan.snapshot-id=1 for the table default.T
+SET paimon.spark.default.T.scan.snapshot-id=1;

Review Comment:
   `spark.paimon`?



##########
docs/content/flink/quick-start.md:
##########
@@ -269,16 +269,27 @@ SELECT * FROM ....;
 ## Setting dynamic options
 
 When interacting with the Paimon table, table options can be tuned without 
changing the options in the catalog. Paimon will extract job-level dynamic 
options and take effect in the current session.
-The dynamic option's key format is 
`paimon.${catalogName}.${dbName}.${tableName}.${config_key}`. The 
catalogName/dbName/tableName can be `*`, which means matching all the specific 
parts.
+The dynamic table option's key format is 
`paimon.${catalogName}.${dbName}.${tableName}.${config_key}`. The 
catalogName/dbName/tableName can be `*`, which means matching all the specific 
parts. 
+The dynamic global option's key format is `paimon.${config_key}`. Global 
options will take effect for all the tables. Table options will override global 
options if there are conflicts.
 
 For example:
 
 ```sql
+-- set scan.timestamp-millis=1697018249001 for all tables
+SET 'paimon.scan.timestamp-millis' = '1697018249001';
+SELECT * FROM T;
+
 -- set scan.timestamp-millis=1697018249000 for the table mycatalog.default.T
 SET 'paimon.mycatalog.default.T.scan.timestamp-millis' = '1697018249000';
 SELECT * FROM T;
 
 -- set scan.timestamp-millis=1697018249000 for the table default.T in any 
catalog
 SET 'paimon.*.default.T.scan.timestamp-millis' = '1697018249000';
 SELECT * FROM T;
+
+-- set scan.timestamp-millis=1697018249000 for the table mycatalog.default.T1

Review Comment:
   outdated?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to