Zouxxyy commented on code in PR #4393:
URL: https://github.com/apache/paimon/pull/4393#discussion_r1828872665
##########
paimon-spark/paimon-spark-common/src/main/scala/org/apache/paimon/spark/SparkSource.scala:
##########
@@ -80,9 +82,15 @@ class SparkSource
}
private def loadTable(options: JMap[String, String]): DataTable = {
+ val path = CoreOptions.path(options)
val catalogContext = CatalogContext.create(
- Options.fromMap(mergeSQLConf(options)),
- SparkSession.active.sessionState.newHadoopConf())
+ Options.fromMap(
Review Comment:
For SparkSource loadTable, maybe we can just keep the original way, because
it is simpler and more general through `spark.read.format("paimon").options()`
to set table level config. And it is difficult to get catalogname and dbname
here
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
